Deduplicate deprecation warning when using unit or tuple structs #147994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
|
rustbot has assigned @petrochenkov. Use |
jieyouxu
reviewed
Oct 22, 2025
This comment has been minimized.
This comment has been minimized.
jdonszelmann
changed the title
jdonszelmann
force-pushed
the
duplicate-warning-struct
branch
from
3cac327 to
47ab7a8
Compare
|
yup, you're right @jieyouxu, ty :3 |
|
This looks like an overkill, and probably a perf regression. |
petrochenkov
added
S-waiting-on-author
jdonszelmann
force-pushed
the
duplicate-warning-struct
branch
from
47ab7a8 to
8e7ccf3
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
@petrochenkov this is indeed much cleaner, thanks for the suggestion! |
petrochenkov
added
S-waiting-on-author
jdonszelmann
force-pushed
the
duplicate-warning-struct
branch
3 times, most recently
from
0fae4ea to
769d54e
Compare
|
ok, made it slightly nicer still I think, where we don't need an explicit loop or separate storage at all |
|
@rustbot review |
rustbot
added
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
Co-authored-by: Waffle Lapkin <waffle.lapkin@gmail.com>
jdonszelmann
force-pushed
the
duplicate-warning-struct
branch
from
769d54e to
a7484b1
Compare
|
@rusbot review |
jdonszelmann
force-pushed
the
duplicate-warning-struct
branch
from
a7484b1 to
1b00911
Compare
WaffleLapkin
approved these changes
Nov 3, 2025
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
Thanks! |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 5, 2025
Rollup of 8 pull requests Successful merges: - #147994 (Deduplicate deprecation warning when using unit or tuple structs) - #148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - #148501 (triagebot: Create Zulip topics for libs backports) - #148517 (Remove no longer necessary lint allow) - #148518 (Unify the configuration of the compiler docs) - #148523 (miri subtree update) - #148525 (Fix ICE from lit_to_mir_constant caused by type error) - #148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 6, 2025
Rollup merge of #147994 - jdonszelmann:duplicate-warning-struct, r=petrochenkov Deduplicate deprecation warning when using unit or tuple structs First commit adds a test that's broken currently, 2nd commit fixes it. Created with `@WaffleLapkin`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 6, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang/rust#148517 (Remove no longer necessary lint allow) - rust-lang/rust#148518 (Unify the configuration of the compiler docs) - rust-lang/rust#148523 (miri subtree update) - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Nov 7, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#147994 (Deduplicate deprecation warning when using unit or tuple structs) - rust-lang/rust#148440 ([rustdoc search] Simplify itemTypes and filter "dependencies") - rust-lang/rust#148501 (triagebot: Create Zulip topics for libs backports) - rust-lang/rust#148517 (Remove no longer necessary lint allow) - rust-lang/rust#148518 (Unify the configuration of the compiler docs) - rust-lang/rust#148523 (miri subtree update) - rust-lang/rust#148525 (Fix ICE from lit_to_mir_constant caused by type error) - rust-lang/rust#148534 (Merge `Vec::push{,_mut}_within_capacity`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit adds a test that's broken currently, 2nd commit fixes it.
Created with @WaffleLapkin